Skip to content

BIP39: add license and copyright section#1680

Merged
murchandamus merged 1 commit intobitcoin:masterfrom
jonatack:2024-10-BIP39-license-and-copyright-section
Feb 4, 2025
Merged

BIP39: add license and copyright section#1680
murchandamus merged 1 commit intobitcoin:masterfrom
jonatack:2024-10-BIP39-license-and-copyright-section

Conversation

@jonatack
Copy link
Copy Markdown
Member

@jonatack jonatack commented Oct 8, 2024

These are required for legal use, and also per BIP-2, and they avoid user confusion as seen in #1395 (comment).

Choice of MIT license per BIP author feedback in #1395 (comment).

The license omission was likely an oversight.

BIP-39 predates BIP-2 by 2-3 years. BIP-1 (in force at the time, since superseded by BIP-2) did require a copyright or public domain section.

These are required per BIP-2, and they avoid user confusion as seen in

bitcoin#1395 (comment)
@jonatack
Copy link
Copy Markdown
Member Author

jonatack commented Oct 8, 2024

cc @prusnak for approval

@prusnak
Copy link
Copy Markdown
Contributor

prusnak commented Oct 8, 2024

ACK

@murchandamus
Copy link
Copy Markdown
Member

Concept ACK, but for a license change, I expect that we need all rights holders to agree. cc: @slush0, @ebfull, @voisine

@kanzure
Copy link
Copy Markdown
Contributor

kanzure commented Oct 8, 2024

is licensing and CLAs addressed in the new bip2 @murchandamus ?

@slush0
Copy link
Copy Markdown
Contributor

slush0 commented Oct 8, 2024

ACK MIT

@jonatack
Copy link
Copy Markdown
Member Author

Pinging @ebfull and @voisine for approval here.

@murchandamus murchandamus added the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label Nov 7, 2024
@murchandamus
Copy link
Copy Markdown
Member

is licensing and CLAs addressed in the new bip2 @murchandamus ?

Just in so far as we have always required an "acceptable license" that permitted others to use the work. My new process BIP draft so far does not propose a CLA.

@bitcoin bitcoin deleted a comment from alexclayton77 Nov 22, 2024
@jonatack
Copy link
Copy Markdown
Member Author

Re-pinging @ebfull and @voisine for approval here.

@bitcoin bitcoin deleted a comment Jan 28, 2025
@bitcoin bitcoin deleted a comment from alexclayton77 Jan 28, 2025
@jonatack
Copy link
Copy Markdown
Member Author

2 BIP authors have ACKed but 2 others are not responding.

@murchandamus we'd want to ensure this case is covered by BIP3.

@murchandamus
Copy link
Copy Markdown
Member

I don’t think this is a case that we can litigate. The authors have the copyright for this document. As far as I am aware, we do not have a record of them licensing it in any different manner than "all rights reserved", and it seems obvious to me that a subset of them cannot update the license, IANAL, though.

FWIW, BIP 3 asserts:

image

@prusnak
Copy link
Copy Markdown
Contributor

prusnak commented Jan 29, 2025

@jonatack @murchandamus have you tried contacting them via email?

@bitcoin bitcoin deleted a comment from alexclayton77 Jan 29, 2025
@murchandamus
Copy link
Copy Markdown
Member

@prusnak: I sent them an email today.

@ebfull
Copy link
Copy Markdown
Contributor

ebfull commented Jan 30, 2025

ACK MIT, sorry for the delay.

@murchandamus
Copy link
Copy Markdown
Member

I did some additional research into this situation. I have come to the understanding that for jointly authored work any of the authors can license the work. Given that we have approval from three authors and BIP 1 already required that any contributions to this repository were placed into public domain or have a copyright statement, it would be hard to argue that BIP 39 was not intended to be licensed compliantly.

Given my updated understanding, I conclude that this is ready to be merged.

@murchandamus murchandamus merged commit b9f9a8d into bitcoin:master Feb 4, 2025
@murchandamus murchandamus removed the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label Feb 4, 2025
@jonatack jonatack deleted the 2024-10-BIP39-license-and-copyright-section branch February 4, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants