Add BIP39 Elixir implementation (mnemo)

[aerosol]

This PR adds another Elixir implementation of BIP39.
Thanks

[luke-jr]

@slush0 @prusnak @voisine @ebfull

[prusnak]

The BIP is not supposed to be the list of all alternatives, but rather provide one really good implementation.

[aerosol]

@prusnak fair, yet unfair - JavaScript and Swift sections link to two implementations on that page.

@izelnakri as the author of the currently linked implementation, would you mind looking at https://github.com/aerosol/mnemo and sharing your thoughts wrt code/tests quality? Cheers!

[prusnak]

@aerosol send a PR that removes the worse of Javascript/Swift implementations

The same applies to Elixir. If you think your implementation is better than the other one, just send a PR that replaces the old one.

[izelnakri]

@aerosol thanks for sharing your work. Could you create a PR with your improvements on https://github.com/izelnakri/mnemonic ? I can add you as a collaborator after we merge your improvements.

[aerosol]

@izelnakri Thanks for looking. Sorry, it's not really feasible to do it chunks and I doubt you meant "submit a PR that replaces the whole repo"

[Fatima-yo]

Hi, I would like to add a new list of words (for a new language) to BIPS-39, how can I do? Thanks in advance, Fatima

…

On Fri, 21 Feb 2020 at 08:01, Adam Rutkowski ***@***.***> wrote: @izelnakri <https://github.com/izelnakri> Thanks for looking. Sorry, it's not really feasible to do it chunks and I doubt you meant "submit a PR that replaces the whole repo" — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#883?email_source=notifications&email_token=AA6FTCPZBHLK5RR52M3SJW3RD6YAPA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSK24A#issuecomment-589606256>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6FTCJ33RQRYTT6VYTKJ3DRD6YAPANCNFSM4KLUE7YQ> .

-- ================================= Fatima Castiglione Maldonado Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord) =================================

[iancoleman]

@Fatima-yo

Have a look at the instructions at

https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md

and also #863 for further info / context on new wordlists.

[Fatima-yo]

Thank you very much, I will do so today :-D

…

On Sun, 23 Feb 2020 at 03:28, iancoleman ***@***.***> wrote: @Fatima-yo <https://github.com/Fatima-yo> Have a look at the instructions at https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md and also #863 <#863> for further info / context on new wordlists. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#883?email_source=notifications&email_token=AA6FTCO5XZQE2ODDKMBXJZDREIJRRA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVS26I#issuecomment-590032249>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6FTCLIOMIH5FNBI7QYN3LREIJRRANCNFSM4KLUE7YQ> .

-- ================================= Fatima Castiglione Maldonado Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord) =================================

[Fatima-yo]

Checking it now... From what I see, a good list would be like follows: 1. Words are 4-8 letters long 2. Words can be uniquely determined by typing the first 4 letters 3. Words are sorting according to the Russian alphabet 4. Priority on simple and common Russian words 5. No words with more than one part 6. No words in the plural 7. No very similar words with 1 letter of difference 8. No demonyms 9. No personal names 10. No geographical names 11. No embarrassing words (in a very, very large scope) 12. No words belonging to a particular religion 13. No words that remind negative/sad/bad things Would that set of rules be OK to add the list to BIP-0039 ? Kindly state. Thanks in advance, Fatima On Mon, 24 Feb 2020 at 11:20, Fatima Castiglione Maldonado < castiglionemaldonado@gmail.com> wrote:

…

Thank you very much, I will do so today :-D On Sun, 23 Feb 2020 at 03:28, iancoleman ***@***.***> wrote: > @Fatima-yo <https://github.com/Fatima-yo> > > Have a look at the instructions at > > https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md > > and also #863 <#863> for further > info / context on new wordlists. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#883?email_source=notifications&email_token=AA6FTCO5XZQE2ODDKMBXJZDREIJRRA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVS26I#issuecomment-590032249>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA6FTCLIOMIH5FNBI7QYN3LREIJRRANCNFSM4KLUE7YQ> > . > -- ================================= Fatima Castiglione Maldonado Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado ***@***.*** (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord) =================================

-- ================================= Fatima Castiglione Maldonado Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord) =================================

[izelnakri]

@izelnakri Thanks for looking. Sorry, it's not really feasible to do it chunks and I doubt you meant "submit a PR that replaces the whole repo"

@aerosol Im not convinced why it cant be done in chunks and requires a whole rewrite to my own repo. Just briefly checked your repo it isnt that big in terms of lines of code or complex to require a complete rewrite.

[aerosol]

@izelnakri Thank you for your assessment. The primary motivation behind writing mnemo was to get a better understanding of BIP39. I found the pre-existing code difficult to reason about (one could say complex), hence I decided to start from scratch. If I had started by forking your repo, I'd happily submit a PR. Otherwise all I can see is two fundamentally different implementations - if you're not convinced, have a look at the tests.