p2p: Remove dead service bits code

[maflcko]

Seems fine to remove for the upcoming 0.17 release

Fixes #10993

[theuni]

I think this is premature. Since it was shipped in 15.0, we need to consider this behavior locked-in until August. We can't practically re-use the bits until then anyway, and we still don't want to remain connected to any peer with them enabled for whatever reason.

Also, I assume the 1 << 5 is still relevant.

[maflcko]

Good point about keeping it in the code for now to make clear that they are taken. Guess there is no rush in merging this.

[Sjors]

Isn't one needed for Bitcoin Cash nodes?

If it can be done without side-effects, it would be a nice gesture to at least deprecate it (earlier).

[maflcko]

Needs rebase. No need to keep open; Closing for now.

[laanwj]

utACK fa4bf92

[Sjors]

Concept ACK

@theuni wrote:

consider this behavior locked-in until August

That should work with the expect v0.17 release, right?

I wrote:

Isn't one needed for Bitcoin Cash nodes?

One year seems long enough for me, especially since they've rolled out multiple hard forks that could have dealt with any potential node confusion (I haven't checked if they did).

[achow101]

utACK fa4bf92

[sipa]

utACK fa4bf92

[laanwj]

utACK fa4bf92