wallet: Unlock spent outputs#13160
Merged
Merged
Conversation
Member
|
Concept ACK |
Member
|
How is this different from #12739? |
Contributor
Author
|
That one allows to unlock the already spent output via RPC (IMO This one automatically removes the output from the locked set when the output is spent. |
Member
|
I have a slight preference for this one. I don't think spent outputs should stay in the 'locked' list. |
promag
force-pushed
the
2018-05-unlock-spent-output
branch
from
6732dbe to
fd9b3a7
Compare
Member
|
utACK fd9b3a7 |
tecnovert
pushed a commit
to particl/particl-core
that referenced
this pull request
May 31, 2018
If true specified outputs are recorded to the wallet database and reloaded at startup. UnlockCoin() will attempt to erase from db if found in set. Including bitcoin PR bitcoin#13160 - Unlock spent outputs.
tecnovert
pushed a commit
to particl/particl-core
that referenced
this pull request
Jun 1, 2018
If true specified outputs are recorded to the wallet database and reloaded at startup. UnlockCoin() will attempt to erase from db if found in set. Including bitcoin PR bitcoin#13160 - Unlock spent outputs.
Contributor
|
utACK fd9b3a7 |
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 19, 2019
13f8d5a [Wallet] Unlock spent outputs (random-zebra) Pull request description: Straightforward update backported from bitcoin#13160 NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite). ACKs for top commit: Fuzzbawls: utACK 13f8d5a furszy: utACK 13f8d5a Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
akshaynexus
added a commit
to dogecash/dogecash-old
that referenced
this pull request
Nov 19, 2019
13f8d5a [Wallet] Unlock spent outputs (random-zebra) Pull request description: Straightforward update backported from bitcoin/bitcoin#13160 NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite). ACKs for top commit: Fuzzbawls: utACK 13f8d5a furszy: utACK 13f8d5a Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
wqking
pushed a commit
to wqking-temp/Vitae
that referenced
this pull request
May 31, 2020
13f8d5aedbcd4e2b1e980555fc95a2619c308094 [Wallet] Unlock spent outputs (random-zebra) Pull request description: Straightforward update backported from bitcoin/bitcoin#13160 NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite). ACKs for top commit: Fuzzbawls: utACK 13f8d5aedbcd4e2b1e980555fc95a2619c308094 furszy: utACK 13f8d5a Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 2, 2020
Summary: fd9b3a7 test: Output should be unlocked when spent (João Barbosa) 54c3bb4 wallet: Unlock spent outputs (João Barbosa) Pull request description: Fixes #12738. Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605 Backport of Core [[bitcoin/bitcoin#13160 | PR13160]] Test Plan: ninja ninja check ninja check-functional Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6321
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 8, 2020
fd9b3a7 test: Output should be unlocked when spent (João Barbosa) 54c3bb4 wallet: Unlock spent outputs (João Barbosa) Pull request description: Fixes bitcoin#12738. Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: fd9b3a7 test: Output should be unlocked when spent (João Barbosa) 54c3bb4 wallet: Unlock spent outputs (João Barbosa) Pull request description: Fixes #12738. Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605 Backport of Core [[bitcoin/bitcoin#13160 | PR13160]] Test Plan: ninja ninja check ninja check-functional Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12738.