Skip to content

test: Switch multiprocess to clang i686 build#22923

Merged
laanwj merged 2 commits into
bitcoin:masterfrom
maflcko:2109-ciClang686
Sep 9, 2021
Merged

test: Switch multiprocess to clang i686 build#22923
laanwj merged 2 commits into
bitcoin:masterfrom
maflcko:2109-ciClang686

Conversation

@maflcko
Copy link
Copy Markdown
Member

@maflcko maflcko commented Sep 8, 2021 •
edited
Loading

Building for i686 with clang helps to catch bugs early for:

  • The OSS-Fuzz i686 clang libFuzzer build
  • The arm 32-bit native clang build

Fixes #22889

@maflcko maflcko mentioned this pull request Sep 8, 2021
Closed
hebasto
hebasto reviewed Sep 8, 2021
View reviewed changes
Comment thread ci/test/00_setup_env_i686_multiprocess.sh Outdated
@DrahtBot DrahtBot added the Tests label Sep 8, 2021
@hebasto
Copy link
Copy Markdown
Member

hebasto commented Sep 8, 2021 •
edited
Loading

Great!

CI catches #22889.

Now add a fix?

@practicalswift
Copy link
Copy Markdown
Contributor

practicalswift commented Sep 9, 2021

Concept ACK

1 similar comment
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 9, 2021

Concept ACK

@maflcko
Copy link
Copy Markdown
Member Author

maflcko commented Sep 9, 2021

Now add a fix?

Done

@maflcko maflcko changed the title ci: Switch multiprocess to clang i686 build test: Switch multiprocess to clang i686 build Sep 9, 2021
hebasto
hebasto approved these changes Sep 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa309ee

@laanwj laanwj merged commit 020c2b7 into bitcoin:master Sep 9, 2021
@maflcko maflcko deleted the 2109-ciClang686 branch September 9, 2021 13:56
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 11, 2021
@laanwj
Merge bitcoin#22923: test: Switch multiprocess to clang i686 build
9c64f0c
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiling fails on 32-bit systems

5 participants

@maflcko @hebasto @practicalswift @laanwj @DrahtBot