Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay#24921
Merged
Hidden character warning
The head ref may contain hidden characters: "2204-steady-clock-\ud83c\udf8e"
Merged
Conversation
maflcko
force-pushed
the
2204-steady-clock-
branch
from
fa223c1 to
fa8da21
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK. I'm lost as to which time PR to look at first at this point, fwiw. |
Member
Author
|
I think we need both, but this one is blocking the addr relay refactor, so review here is minimally more appreciated. |
maflcko
force-pushed
the
2204-steady-clock-
branch
from
fa8da21 to
fada593
Compare
maflcko
force-pushed
the
2204-steady-clock-
branch
from
fada593 to
fa4fb8d
Compare
Member
Author
|
Added doxygen to |
Contributor
|
ACK fa4fb8d |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 10, 2022
…nd FastRandomContext::rand_uniform_delay fa4fb8d random: Add FastRandomContext::rand_uniform_delay (MarcoFalke) faa5c62 Add time helpers for std::chrono::steady_clock (MarcoFalke) Pull request description: A steady clock can be used in the future for the scheduler, for example. A random uniform delay applied to a time point can be used in the future for time points passed to the scheduler, or delays in net processing. Currently they are unused outside of tests, but if they turn out unused in the future (unlikely), they can trivially be removed again. I am splitting them out, so that several branches/pulls can build on top of them without duplicating the commits. ACKs for top commit: ajtowns: ACK fa4fb8d Tree-SHA512: 2c37174468fe84b1cdf2a032f458706df44b99a5f99062417bb42078b6f69e2f1738d20c21cd9386ca5a35f3bc0583e547ba40168c66f6aa42f700ba35dd95d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A steady clock can be used in the future for the scheduler, for example.
A random uniform delay applied to a time point can be used in the future for time points passed to the scheduler, or delays in net processing.
Currently they are unused outside of tests, but if they turn out unused in the future (unlikely), they can trivially be removed again. I am splitting them out, so that several branches/pulls can build on top of them without duplicating the commits.