refactor: Avoid passing params where not needed#25168
Merged
Hidden character warning
The head ref may contain hidden characters: "2205-remove-bloat-\ud83c\udfee"
Merged
Conversation
added 5 commits
May 18, 2022 18:44
Member
|
Concept ACK |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced May 19, 2022
Contributor
|
Code review ACK fa1b76a. |
This was referenced May 20, 2022
Contributor
|
post-merge ACK. This synergizes well with some of the upcoming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems confusing to pass chain params, consensus params, or a time function around when it is not needed.
Fix this by:
chainman.GetConsensus()orchainman.GetParams(), where possible.