psbt: s/transcation/transaction/#26997
Merged
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
jonatack
reviewed
Jan 30, 2023
| // Make sure that we got an unsigned tx | ||
| if (!tx) { | ||
| throw std::ios_base::failure("No unsigned transcation was provided"); | ||
| throw std::ios_base::failure("No unsigned transaction was provided"); |
Member
There was a problem hiding this comment.
maybe also fix up this one that was recently added in 1429f83
$ ./test/lint/lint-spelling.py
src/blockencodings.h:138: overriden ==> overridden
Member
There was a problem hiding this comment.
Another one now, may as well get 'em all in this fixup commit.
$ test/lint/lint-spelling.py
src/blockencodings.h:138: overriden ==> overridden
src/net.cpp:1668: addressses ==> addresses
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 16, 2023
9066314 s/transcation/transaction/ (Greg Sanders) Pull request description: ACKs for top commit: fanquake: ACK 9066314 - looks like other comments are being addressed elsewhere. Tree-SHA512: c835a14db2e0cf5e0317c95c8c7441df1f7c6cb14be7809fd947e07ea9d23f1f171f111429aabd0509b7f17601bc742041316b18e1135e547a966961f2c65038
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.