test: Fix test log file name#30654
Conversation
bitcoin#19385 dropped `.cpp` infix. However, `src/test/README.md` still refers to the `foo_tests.cpp.log` pattern.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
Not sure this PR should be called a "fix"? As it seems the fix would be to just update the docs to match the current (intended) behaviour. This instead seems to be a reversion to prior behaviour to facilitate something CMake related. I'm curious why this has only become an issue now, given we've already got the tests in CMake? Or is this something that was missing and is being ported now? |
|
Not sure about changing the test-only behavior here. Seems fine to just adjust the readme in the cmake pull, as the line has to be touched anyway. No need to be exact in porting this edge case? |
I had some concerns while documenting CTest behaviour in hebasto#329. |
#19385 dropped
.cppinfix (see #19385 (comment) and #19385 (comment)). However,src/test/README.mdstill refers to thefoo_tests.cpp.logpattern:bitcoin/src/test/README.md
Line 113 in e682e7d
This PR restores the pre-PR19385 behaviour, as appending is easier to implement than replacing when porting this functionality to CMake.