Skip to content

Remove log level #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
notmandatory merged 2 commits into from
Dec 24, 2020
Merged

Remove log level #2

notmandatory merged 2 commits into from
Dec 24, 2020

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 18, 2020

Description

This issue fixes #1 by removing the --log_level option which was overriding the RUST_LOG environment variable but does not provide the same level of logging control.

Notes to the reviewers

Also in this PR I added a couple more usage examples in the README, including an example for using the RUST_LOG env variable.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory
Copy link
Member Author

notmandatory commented Dec 18, 2020 •
edited
Loading

@RCasatta I moved #1 to the new bdk-cli repo and this is the fix for it.

@notmandatory notmandatory force-pushed the remove_log_level branch 2 times, most recently from 7ad537e to 4f61bb8 Compare December 18, 2020 16:44
@notmandatory notmandatory changed the base branch from main to master December 18, 2020 16:57
RCasatta
RCasatta reviewed Dec 22, 2020
View reviewed changes
@notmandatory notmandatory merged commit 9ce5a56 into bitcoindevkit:master Dec 24, 2020
@notmandatory notmandatory deleted the remove_log_level branch December 24, 2020 04:38
@notmandatory notmandatory mentioned this pull request Dec 28, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RCasatta RCasatta RCasatta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

log level in cli

2 participants

@notmandatory @RCasatta