Skip to content

chore(deps): update uniffi-dart to v0.2.0+v0.31.1#67

Merged
reez merged 1 commit intobitcoindevkit:mainfrom
Johnosezele:uniffi-update
Apr 30, 2026
Merged

chore(deps): update uniffi-dart to v0.2.0+v0.31.1#67
reez merged 1 commit intobitcoindevkit:mainfrom
Johnosezele:uniffi-update

Conversation

@Johnosezele
Copy link
Copy Markdown
Contributor

closes #66

Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from review. The dependency bump itself looks reasonable and current CI is green.

One caveat I found while reviewing: after updating to uniffi-dart v0.2.0+v0.31.1, repeated runs of bash ./scripts/generate_bindings.sh can rewrite lib/bdk.dart with FFI converter declaration-order churn even when the generated class set is unchanged. That looks like an upstream uniffi-dart codegen determinism issue rather than a wallet/runtime correctness problem. We should track it upstream, but I do not think it needs to block this PR.

Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1297dc7

Non-blocking note: noisy regenerated diffs that im going to open up an issue about to see if there is a problem or not.

@reez reez merged commit eb96269 into bitcoindevkit:main Apr 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new upstream uniffi-dart releases

2 participants