Add flush method to wallet#115
Closed
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
afd930e to
e398529
Compare
e398529 to
5a53906
Compare
Member
|
I think this one can be closed in favor of using sqlite db from #116. |
Member
Author
|
Agreed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cannot be merged before the
flush()method is added to bdk (see upcoming PR)This fixes #114. Took @notmandatory and I half a day to do it all, but we fully tested the new flush method and it did resolve the bug.
Note that at the moment the
database()method on the wallet returns an immutable reference, hence why we cannot simply do:directly in bdk-ffi to trigger the flush.