Change TxBuilder.finish() to return new TxBuilderResult#209
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Oct 19, 2022
Merged
Change TxBuilder.finish() to return new TxBuilderResult#209notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
Member
Author
|
If this looks OK should we try to get this into 0.10.0? or wait for 0.11.0 when we should also have the FeeRate calculation? |
5834069 to
c117359
Compare
c117359 to
fadb316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change TxBuilder.finish() to return new TxBuilderResult.
Notes to the reviewers
This fixes #179 in that it return both PartiallySignedBitcoinTransaction and TransactionDetails encapsulated in a new TxBuilderResult structure. It does not calculate the fee rate which requires #208.
Changelog notice
TxBuilder.finish()to return newTxBuilderResult.TxBuilderResultwith PSBT and TransactionDetails.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: