Skip to content

Change TxBuilder.finish() to return new TxBuilderResult#209

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:txbuilder_details
Oct 19, 2022
Merged

Change TxBuilder.finish() to return new TxBuilderResult#209
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:txbuilder_details

Conversation

@notmandatory
Copy link
Copy Markdown
Member

Description

Change TxBuilder.finish() to return new TxBuilderResult.

Notes to the reviewers

This fixes #179 in that it return both PartiallySignedBitcoinTransaction and TransactionDetails encapsulated in a new TxBuilderResult structure. It does not calculate the fee rate which requires #208.

Changelog notice

  • Breaking Changes
    • Changed TxBuilder.finish() to return new TxBuilderResult.
  • APIs Added
    • Added TxBuilderResult with PSBT and TransactionDetails.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory
Copy link
Copy Markdown
Member Author

If this looks OK should we try to get this into 0.10.0? or wait for 0.11.0 when we should also have the FeeRate calculation?

@notmandatory notmandatory marked this pull request as ready for review October 19, 2022 17:27
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fadb316.

@thunderbiscuit thunderbiscuit added this to the Release 0.10.0 milestone Oct 19, 2022
@notmandatory notmandatory merged commit 1f914c2 into bitcoindevkit:master Oct 19, 2022
@notmandatory notmandatory mentioned this pull request Oct 19, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Consider returning TransactionDetails from TxBuilder finish() method

2 participants