Add Transaction struct, update PSBT and Blockchain to use it#296
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 23, 2023
Merged
Conversation
b333000 to
4b28398
Compare
d5d81cf to
f8037d7
Compare
f8037d7 to
1ce5546
Compare
Member
Author
|
I marked this as ready to review, it's rebased and I don't expect any more code changes. But I still need to do manual testing to confirm the transaction broadcast. |
1ce5546 to
8e54ada
Compare
thunderbiscuit
approved these changes
Jan 23, 2023
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
Tested ACK 8e54ada. I ran a script using bdk-jvm and your test vector. Looks good! Another win for the LDK/BDK integration.
This was referenced Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new
Transactionstructure that can be created from transaction consensus encoded bytes. UpdatePartiallySignedTransaction.extract_tx()to return aTransactioninstead of a the transaction bytes. UpdateBlockchain.broadcast()to take aTransactionparameter.Notes to the reviewers
Fixes #157.
Changelog notice
Added
Transactionstructure that can be created from or serialized to consensus encoded bytes.Changed
PartiallySignedTransaction.extract_tx()returns aTransactioninstead of a the transaction bytes.Blockchain.broadcast()takes aTransactioninstead of aPartiallySignedTransaction.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: