feat(descriptor): add bip-86 template

[reez]

Description

This PR adds the descriptor template for bip-86.

Links

Merged bdk Pull Request adding BIP-86 template

Docs for BIP-86 template

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[notmandatory]

Looks good! we should make a local swift package with this branch and try it out in your example ios wallet.

[reez]

Looks good! we should make a local swift package with this branch and try it out in your example ios wallet.

Can do!

[thunderbiscuit]

Tested. Looks good! Would you mind adding to the tests that start on line 266? Just for completeness since the other 3 templates are tested/showcased there.

I also think we can remove the comment on line 304; the templates are now showing correct coin types on testnet.

Otherwise ready to go IMO.

[reez]

Looks good! we should make a local swift package with this branch and try it out in your example ios wallet.

Just created a local swift package off of this branch and tried it out in the iOS wallet creating and using a bip-86 wallet, and it worked great.

[reez]

Tested. Looks good! Would you mind adding to the tests that start on line 266? Just for completeness since the other 3 templates are tested/showcased there.

I also think we can remove the comment on line 304; the templates are now showing correct coin types on testnet.

Otherwise ready to go IMO.

Definitely! The code is updated now, and tests pass ✅.

• Added tests for bip-86
• removed comment on line 304



Note


I changed line 307


let template_private_84 = Descriptor::new_bip84(master, KeychainKind::External, Network::Testnet);


to


let template_private_84 = Descriptor::new_bip84(master.clone(), KeychainKind::External, Network::Testnet);


just because of the ownership rules since I added the line


let template_private_86 = Descriptor::new_bip86(master, KeychainKind::External, Network::Testnet);


after that line.


The other quick option was to just add .clone() to both of those lines, but I kept things similar to how it was before and just made the last of those lines (template_private_86) not have .clone().

[thunderbiscuit]

Tested ACK c3e8469.

[thunderbiscuit]

@reez do you mind rebasing this on master? I'll merge right away. Sorry this took so long to review/get in.