deps: bump bdk to beta_5#600
Conversation
reez
force-pushed
the
beta-5
branch
2 times, most recently
from
874a522 to
280eecb
Compare
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Very nice cleanup.
I have one tiny thing I'd like to clean up before merging, but that's it.
Nice work; I like the removal of the explicit rbf setter, and we're probably the first ones to do that by default!
| bdk_esplora = { version = "0.18.0", default-features = false, features = ["std", "blocking", "blocking-https-rustls"] } | ||
| bdk_electrum = { version = "0.18.0", default-features = false, features = ["use-rustls-ring"] } | ||
| bdk_bitcoind_rpc = { version = "0.15.0" } | ||
| bdk_wallet = { version = "1.0.0-beta.5", features = ["all-keys", "keys-bip39", "rusqlite"] } |
There was a problem hiding this comment.
Here I think we should pin the bdk_wallet dependency to beta 5. The default cargo behaviour of updating to the latest patch broke my (and all of our) builds as of yesterday when they released beta 5 which contained a breaking change. This is not a bdk problem but really a cargo problem.
There was a problem hiding this comment.
I pushed an update to pin, but just double check its what you were asking for and I won't merge or anything until you give it the go ahead that this is good-
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Sorry I chose "Approve" when I should have clicked "Request changes".
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK 6cfcf23. Ready to merge.
2 participants
Description
This pull request updates the bdk-ffi crate to use the latest beta version of bdk, specifically version 1.0.0-beta.5.
The main changes include:
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: