feat: transactions use transactions_sort_by#617
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Nov 14, 2024
Merged
Conversation
8 tasks
Collaborator
Author
|
Attempting to fix this failing CI on swift with #618 |
Collaborator
Author
Collaborator
|
ACK 16a6bc8 |
Collaborator
Author
|
rebased, will merge after tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After discussing possible paths in #592 I believe the consensus was to just use transactions_sort_by under the hood in
transactionsbecause the example is likely what clients would expect out of the box.Notes to the reviewers
I tested a local build of this in BDKSwiftExampleWallet to verify it worked as intended.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: