Add small Kyoto integration test#965
Open
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Add small Kyoto integration test#965thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
new-kyoto
branch
from
bcb9ca6 to
c0925a0
Compare
7 tasks
Collaborator
|
Do we know why CI is failing? |
Member
Author
reez
reviewed
Mar 9, 2026
reez
reviewed
Mar 9, 2026
reez
reviewed
Mar 9, 2026
Collaborator
reez
left a comment
reez
left a comment
There was a problem hiding this comment.
Looks good overall and consistent w bdk kyoto, a couple questions comments added
Member
Author
|
I'll update and rebase this once #967 is in, leveraging the regtest on CI. |
Collaborator
ack'd 967 |
thunderbiscuit
force-pushed
the
new-kyoto
branch
from
c0925a0 to
4fdb31f
Compare
thunderbiscuit
force-pushed
the
new-kyoto
branch
from
4fdb31f to
0377273
Compare
thunderbiscuit
changed the title
reez
reviewed
Apr 28, 2026
| } catch (e: CbfException) { println("Info channel closed: $e") } | ||
| } | ||
|
|
||
| val update: Update = client.update() |
Collaborator
There was a problem hiding this comment.
Could this hang in CI if client.update() never returns?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: this is now simply adding an integration test for Kyoto, the kind that would have caught our little bug in the 2.3.0 release of the client. It uses the CI regtest environment brought in with #967.
Trying to connect the dots from bdk_kyoto all the way to the the bindings. bitcoindevkit/bdk-kyoto#146