chore: bump bdk_wallet 3.0.0 and bdk_kyoto 0.16.0#978
chore: bump bdk_wallet 3.0.0 and bdk_kyoto 0.16.0#978reez merged 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Just one little thing I think could use a small cleanup (and it's more of a look/consistency comment rather than logic issue so could be fixed later if needed), otherwise ready to go.
| local_chain, | ||
| tx_graph, | ||
| indexer, | ||
| locked_outpoints: bdk_wallet::locked_outpoints::ChangeSet { |
There was a problem hiding this comment.
The other fields (tx_graph, local_chain) have their own From trait implemented, making the code here look seamless (value.indexer.into(), value.tx_graph.into()). I was wondering why locked_outpoint was different and I think it doesn't need to be; if you extract the logic from 1313-1317 into the From trait we should be able to just call value.locked_outpoints.into() like we do for the other fields.
There was a problem hiding this comment.
This will also I think clean up the call site here on line 1325.
| let local_chain = value.local_chain.into(); | ||
| let tx_graph = value.tx_graph.into(); | ||
| let indexer = value.indexer.into(); | ||
| let locked_outpoints = value |
There was a problem hiding this comment.
Similar comment to above, but the conversion would happen the other way.
Good call on those. Will update |
|
Updated based on feedback ✅ |
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK 7deab3d. A small step for reez, a big step for BDK!
2 participants
Description
Bumping to 3.0 (and compatibility changes)
Notes to the reviewers
The smallest first unit of work from #971 ... after which all other 3.0 related PR's can be added to.
Documentation
bdk_walletbitcoinuniffiChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: