Add a Swift version of WalletSetupBip32#981
Open
RowDaBoat wants to merge 3 commits intobitcoindevkit:masterfrom
Open
Add a Swift version of WalletSetupBip32#981RowDaBoat wants to merge 3 commits intobitcoindevkit:masterfrom
RowDaBoat wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
e2e6fdf to
9ae06a2
Compare
j-kon
suggested changes
Apr 24, 2026
Contributor
j-kon
left a comment
There was a problem hiding this comment.
Thanks for adding this Swift example. I found one user-facing issue that should be fixed before this lands.
bdk-swift/README.md documents swift run WalletSetupBip32Example, but the executable added in bdk-swift/Package.swift is named WalletSetupBip32, and the CI change builds that same target. As written, the README command will fail because there is no executable product with that name.
I think the README command should be changed to swift run WalletSetupBip32.
Aside from that, this looks aligned with issue #818 and mirrors the JVM example closely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Showing users how the APIs can be used across languages is valuable. This PR mirrors the WalletSetupBip32 JVM example in Swift as requested in issue 818.
Notes to the reviewers
This Swift example follows the Kotlin example as closely as possible.
Checklists
All Submissions:
swift buildandswift runbefore committingNew Features: