test: remove noisy print statements#982
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 24, 2026
Merged
Conversation
thunderbiscuit
requested changes
Apr 24, 2026
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
One tiny fix I'd like to see and this is ready to go! Thanks for working on this.
| let unknown = &psbt_inputs[0].unknown; | ||
| println!("Unknown field in Psbt Input: {:?}", unknown); | ||
| assert_eq!(psbt_inputs.len(), 1); | ||
| assert_eq!(unknown.len(), 1); |
Member
There was a problem hiding this comment.
I'm not sure why we're testing the length of the unknown field here but let's remove this line while we're at it!
088a427 to
f8f8bfd
Compare
Contributor
Author
|
Thanks, I removed that extra I re-ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unconditional debug/print output from a small set of Rust test files where the assertions already provide enough signal on failure.
Scope
This change is intentionally limited to test cleanup in:
bdk-ffi/src/tests/descriptor.rsbdk-ffi/src/tests/keys.rsbdk-ffi/src/tests/bitcoin.rsI left
tx_builder.rsunchanged in this pass because those prints are mixed into live-network and failure-diagnostic paths, so I wanted to keep the scope conservative.What changed
println!calls from descriptor template/address-data/psbt-related tests where they were only adding noise on successdbg!calls from key teststest_to_address_datawith explicit variant assertionsVerification
cargo fmt --checkcargo test descriptorcargo test psbtcargo test test_to_address_datacargo test test_from_str_inner