Skip to content

refactor: use types::KeychainKind where appropriate#985

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit:keychainkind
Apr 30, 2026
Merged

refactor: use types::KeychainKind where appropriate#985
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit:keychainkind

Conversation

@thunderbiscuit
Copy link
Copy Markdown
Member

This small fix came up in my review of #971. I realized we used what looked like on the surface to be 2 versions of the KeychainKind type, one directly from bdk_wallet and one from our custom-written types.

This is not the case and they were both coming from our custom-written types, but the imports made this confusing and not obvious. This PR fixes that.

Documentation

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb1b6fa

yeah this is a nice change/cleanup

@thunderbiscuit thunderbiscuit merged commit d0f711f into bitcoindevkit:master Apr 30, 2026
4 checks passed
@thunderbiscuit thunderbiscuit mentioned this pull request Apr 30, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants