More and better tests#18
Conversation
17d51bd to
9c1a61a
Compare
ItoroD
left a comment
There was a problem hiding this comment.
Your additional tests for the multipath work well with master (bdk-ffi)!
I have noted you have more things you will like to add here 👍. Looking good so far.
|
|
||
| @Test | ||
| fun `Descriptors can be created from multipath public descriptor string`() { | ||
| Descriptor("tr($TEST_EXTENDED_PUBKEY/<0;1>/*)", Network.REGTEST) |
There was a problem hiding this comment.
Just a nit.
For completeness sake, will we want to add the other test networks
a23c104 to
6d582c1
Compare
|
@ItoroD this is ready for final review. I have updated the submodule to the latest commit on master for bdk-ffi so that the tests for the 2 new APIs can work. Note that I did not fix the Kyoto example in this PR, so the CI fails but only on that. |
baf1d0e to
147539d
Compare
PR #22 fixes the kyoto sample error. I also updated submodule to latest from master just like you have here commit: |
|
Yeah I think merging yours first makes more sense. I'll rebase this after. Thanks for the review! |
147539d to
568d730
Compare
I'll keep this one open until some of my bdk-ffi PRs are in and I'll add tests for them here.
The first commit on this PR streamlines our use of extended keys public and private. I introduced two mnemonics:
Which are then used to produce the keys, descriptors, ect.
Todo
Wallet::create_singlemethod bdk-ffi#825Wallet::create_from_two_path_descriptorconstructor bdk-ffi#847