Scanning fails when birthday block does not exist#57
Merged
nymius merged 1 commit intobitcoindevkit:masterfrom Apr 13, 2026
Merged
Scanning fails when birthday block does not exist#57nymius merged 1 commit intobitcoindevkit:masterfrom
nymius merged 1 commit intobitcoindevkit:masterfrom
Conversation
When the wallet is just created, there is no blocks on the LocalChain, making the request of the birthday checkpoint impossible to serve. This change avoids the issue by directly using the height and hash set on the wallet.birthday field.
Collaborator
Author
|
self ACK c5c22ad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the wallet is just created, there is no blocks on the
LocalChain, making the request of the birthday checkpoint impossible to serve.This change avoids the issue by directly using the height and hash set on the wallet.birthday field.