fix(finalizer): set finalized to false on error and add full coverage#44
Merged
ValuedMammal merged 2 commits intobitcoindevkit:masterfrom Apr 11, 2026
Merged
Conversation
Collaborator
|
Why not use |
noahjoeris
force-pushed
the
add-finalizer-tests
branch
from
17f3734 to
cfdad3d
Compare
Contributor
Author
|
yep makes sense. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in Finalizer::finalize() where finalized remained true after an input finalization error, for example when a signature is missing. That could cause PSBT output metadata to be cleared even though finalization did not fully succeed.
I also added tests with full coverage.