fix(rbf): include evicted descendants in replacement fee floor#50
Open
noahjoeris wants to merge 3 commits intobitcoindevkit:masterfrom
Open
fix(rbf): include evicted descendants in replacement fee floor#50noahjoeris wants to merge 3 commits intobitcoindevkit:masterfrom
noahjoeris wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: When replacing a tx that has unconfirmed descendants in the mempool, those descendants are evicted along with it but their fees were not counted toward the replacement's required fee. This allowed under-paying replacements that a node would reject.
Fix:
RbfSet::newgains adescendantsparameter -> breaking changeVec::contains(O(n)) →HashSet(O(1)).