Skip to content

fix(rbf): include evicted descendants in replacement fee floor#50

Open
noahjoeris wants to merge 3 commits intobitcoindevkit:masterfrom
noahjoeris:fix/rbf
Open

fix(rbf): include evicted descendants in replacement fee floor#50
noahjoeris wants to merge 3 commits intobitcoindevkit:masterfrom
noahjoeris:fix/rbf

Conversation

@noahjoeris
Copy link
Copy Markdown
Contributor

Description

Problem: When replacing a tx that has unconfirmed descendants in the mempool, those descendants are evicted along with it but their fees were not counted toward the replacement's required fee. This allowed under-paying replacements that a node would reject.

Fix:

  • Evicted descendants now count toward the replacement fee floor; previously their fees were dropped.
  • RbfSet::new gains a descendants parameter -> breaking change
  • Descendant traversal: Vec::contains (O(n)) → HashSet (O(1)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant