fix(deps): replace deprecated FeeRate::from_sat_per_vb_unchecked#51
Open
noahjoeris wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(deps): replace deprecated FeeRate::from_sat_per_vb_unchecked#51noahjoeris wants to merge 1 commit intobitcoindevkit:masterfrom
noahjoeris wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FeeRate::from_sat_per_vb_uncheckedgot deprecated inbitcoin-units 0.1.3, which broke CIFeeRate::from_sat_per_vb(n)everywherefrom_sat_per_vbinstead offrom_sat_per_vb_u32for compatibility.from_sat_per_vb_u32would require a direct bitcoin-units >= 0.1.3 constraint; bitcoin only requires bitcoin-units = "0.1.0", so it can still resolve to versions without that API