Skip to content

log dependency forces version for non-MSRV builds #1013

@tcharding

Description

@tcharding

Currently the log dependency is set to a fixed version v0.4.18, this was done to keep the MSRV build passing however there is a better approach available. The problem with this approach is that it forces the log version even for non-MSRV builds and for folk with a more recent version of log in their dependency tree it forces them to have both versions in their dependency tree.

Instead we can pin the log dependency in CI when doing the MSRV build, this proves that the code builds for the stated MSRV while not forcing users of bdk to use the same version.

See bitcoindevkit/rust-esplora-client#51 for an attempt at doing so in rust-esplora-client (be warned that I've not fully worked out the github actions syntax yet, in rust-bitcoin we use shell scripts to do the pinning).

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions