Ignore rocksdb audit error RUSTSEC-2022-0046#1007
Merged
notmandatory merged 1 commit intobitcoindevkit:release/0.28from Jul 19, 2023
Merged
Ignore rocksdb audit error RUSTSEC-2022-0046#1007notmandatory merged 1 commit intobitcoindevkit:release/0.28from
notmandatory merged 1 commit intobitcoindevkit:release/0.28from
Conversation
notmandatory
force-pushed
the
rocksdb_audit_ignore
branch
from
78355c5 to
f7d0852
Compare
|
Concept ACK I verified the vulnerability and the fact that the current usage wouldn't trigger it anyways. Being an experimental feature compounds upon the reasons for the ACK. |
16 tasks
19 tasks
danielabrozzoni
approved these changes
Jul 18, 2023
Member
danielabrozzoni
left a comment
danielabrozzoni
left a comment
There was a problem hiding this comment.
ACK f7d0852 - bdk is not affected by this vulnerability, as we never call rocksdb::DBWithThreadMode::open_cf_descriptors_with_ttl()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1006.
Notes to the reviewers
The
compact_filtersfeature is marked as experimental and we don't use the rocksdb "multiple column families with TTL" feature mentioned in this advisory. Also this feature will be completely reworked for the bdk 1.0 release.Changelog notice
None
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: