Skip to content

Impl Ord for Condition#1014

Closed
benthecarman wants to merge 1 commit intobitcoindevkit:masterfrom
benthecarman:no-std
Closed

Impl Ord for Condition#1014
benthecarman wants to merge 1 commit intobitcoindevkit:masterfrom
benthecarman:no-std

Conversation

@benthecarman
Copy link
Copy Markdown
Contributor

This was missed in #894

Tried using master for Mutiny and we get compile errors without having this

@notmandatory
Copy link
Copy Markdown
Member

Clippy is complaining because you implemented Ord but using the default derived version of PartialOrd. Where in your code do you need Ord? If it's for sorting something can you pass in your own function there instead of making this the global Ord impl for bdk?

@benthecarman
Copy link
Copy Markdown
Contributor Author

This is just so you can compile bdk with no-std and wasm32

can test with cargo check --no-default-features --features bitcoin/no-std,miniscript/no-std,bdk_chain/hashbrown --target wasm32-unknown-unknown

@benthecarman benthecarman deleted the no-std branch June 23, 2023 01:52
@benthecarman
Copy link
Copy Markdown
Contributor Author

Figured out this issue, need to include bdk_chain with the hashbrown feature

@notmandatory notmandatory removed this from the 1.0.0-alpha.1 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants