Fix cargo features#1017
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jun 26, 2023
Merged
Conversation
evanlinjin
force-pushed
the
fix_cargo_features
branch
2 times, most recently
from
72e1e81 to
89e0e90
Compare
* `bdk_chain/std` should also enable `miniscript/std` * use the version of `hashbrown` that `bitcoin` and `miniscript` is using
evanlinjin
force-pushed
the
fix_cargo_features
branch
from
89e0e90 to
26ade11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following commands failed on
master:This PR introduces the following fixes:
bdk_chain/stdshould also enableminiscript/stdhashbrownthatbitcoinandminiscriptusesNotes to the reviewers
Changelog notice
hashbrownto0.11(the version thatbitcoinandminiscriptuses).stdfeature flags forbdk_chain.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
* [ ] This pull request breaks the existing API* [ ] I've added tests to reproduce the issue which are now passing* [ ] I'm linking the issue being fixed by this PR