Test status of reorg tx#1124
Closed
vladimirfomene wants to merge 13 commits intobitcoindevkit:masterfrom
Closed
Conversation
We remove `ElectrumUpdate` and return tuples instead for `ElectrumExt` methods. We introduce the `IncompleteTxGraph` structure to specifically hodl the incomplete `TxGraph`. This change is motivated by @LLFourn's comment: bitcoindevkit@794bf37#r1305432603
Co-authored-by: Steve Myers <steve@notmandatory.org>
Also introduce `bitcoind_rpc` cli example. Add tests: * `test_sync_local_chain` ensures that `Emitter::emit_block` emits blocks in order, even after reorg. * `test_into_tx_graph` ensures that `into_tx_graph` behaves appropriately for both mempool and block updates. It should also filter txs and map anchors correctly.
Replaced `into_tx_graph_update` with `indexed_tx_graph_update`. The latter returns a vec of `(tx, anchors, last_seen)` to be passed into `IndexedTxGraph::insert_relevant_txs`.
40 tasks
39 tasks
Member
|
Thank you for taking a crack at this. Due to time constraints, I've already implemented reorg tests in #1041 |
Contributor
Author
|
@evanlinjin that is okay, I don't mind us closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR checks that the status of reorg transaction is
unconfirmed. It builds on top of #1041.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: