Remove TxGraph::missing_heights as ChangeSet::missing_heights_from should have replaced it#1126
Closed
evanlinjin wants to merge 3 commits intobitcoindevkit:masterfrom
Closed
Remove TxGraph::missing_heights as ChangeSet::missing_heights_from should have replaced it#1126evanlinjin wants to merge 3 commits intobitcoindevkit:masterfrom
TxGraph::missing_heights as ChangeSet::missing_heights_from should have replaced it#1126evanlinjin wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
evanlinjin
force-pushed
the
rm_missing_heights
branch
2 times, most recently
from
301558c to
6406d53
Compare
Also publicly expose `bdk::wallet::Update` as `bdk::Update`.
We use `ChangeSet::missing_heights_from` in favour of `TxGraph::missing_heights`. `test_missing_blocks` is renamed to `test_changeset_missing_blocks_from` and the test is updated.
evanlinjin
force-pushed
the
rm_missing_heights
branch
from
6406d53 to
8e82bfa
Compare
evanlinjin
force-pushed
the
rm_missing_heights
branch
from
59f75fb to
0509f11
Compare
40 tasks
Member
|
I'm moving this back to new alpha.4 release since it looks like a large-ish functional change. |
Collaborator
|
I think I've expressed directly to evan that I think this is a bad change. |
54 tasks
55 tasks
Collaborator
|
Haven't heard anything back from @evanlinjin so closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChangeSet::missing_heights_fromis introduced as a simpler alternative toTxGraph::missing_heights. We should removeTxGraph::missing_heightsand useChangeSet::missing_heights_frominstead.Notes to the reviewers
WIP
Changelog notice
Remove
TxGraph::missing_heightsand useChangeSet::missing_heights_frominstead.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: