Skip to content

fix: Add the pinning of time/cc in README#1137

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
danielabrozzoni:ci/pin_time_cc
Oct 3, 2023
Merged

fix: Add the pinning of time/cc in README#1137
notmandatory merged 2 commits intobitcoindevkit:masterfrom
danielabrozzoni:ci/pin_time_cc

Conversation

@danielabrozzoni
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni commented Sep 29, 2023

Should have been in #1135, sorry.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Oct 1, 2023

You'll need to copy-pasta or cherry-pick 2ecd3e0 to fix code coverage workflow and then we can merge this. :-)

@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Oct 2, 2023

Thanks, updated!

notmandatory
notmandatory approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f28e665

@notmandatory notmandatory merged commit 9bd5286 into bitcoindevkit:master Oct 3, 2023
@notmandatory notmandatory added the ci label Oct 3, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Oct 3, 2023
@danielabrozzoni danielabrozzoni deleted the ci/pin_time_cc branch October 11, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels

None yet

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-alpha.2

Development

Successfully merging this pull request may close these issues.

2 participants

@danielabrozzoni @notmandatory