chore: remove bdk dependency on log and dev dependency on env_logger#1204
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Nov 20, 2023
Merged
Conversation
Member
|
Should we open an issue to introduce some sort of diy logger as ldk does? ACK 18e9e0a |
Closed
Member
Author
I just created a placeholder issue. |
54 tasks
18e9e0a to
02fa340
Compare
Member
Author
|
rebased |
55 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As suggested by @TheBlueMatt we shouldn't use the
logcrate because even though it is a rust-lang project is may depend on some other crates that aren't as well maintained. Since we were only uselogin a few places and not it any other bdk workspace projects except thebdkpackage I removed it.Notes to the reviewers
For consistency I also removed the
env_loggerfrom the dev dependencies since it was only being used in a few places in a couple examples and println! is adequate for examples.Changelog notice
None
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing