fix: clippy warnings#1214
Closed
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
Member
|
Just realized, this needs a rebase |
Contributor
|
Relevant: https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html#whats-in-1740-stable Just released now for Rust 1.74 |
54 tasks
Member
Author
|
Looks like the clippy problems I found were fixed in other recently merged PRs so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix clippy warnings: useless_conversion, default_constructed_unit_structs, useless_vec.
Notes to the reviewers
These clippy warning started popping up as errors in recent CI runs.
Changelog notice
None.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing