Fix: apply loaded changeset to indexed_graph when loading a wallet from persistence#1246
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Dec 26, 2023
Conversation
Member
|
This one will need to be rebased once #1247 has been merged, that will fix the clippy and 1.63.0 errors. |
thunderbiscuit
force-pushed
the
fix-load-from-changeset
branch
from
d64bdc9 to
f4863c6
Compare
evanlinjin
approved these changes
Dec 26, 2023
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ACK f4863c6
Thanks for catching this large oversight of mine 😥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the tx_graph from the changeset when loading a wallet from persistence. This ensures among other things that the revealed keychain indices get picked up by the new wallet. A test for this has been added/modified from an old test.
Notes to the reviewers
Changelog notice
Fix: loading a wallet from persistence now restores keychain indices.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: