cherry-pick feat(wallet)!: add NonEmptyDatabase variant to NewError#1256
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Jan 6, 2024
Merged
Conversation
3 tasks
`NewError` is the error type when constructing a wallet with `Wallet::new`. We want this to return an error when the database already contains data (in which case, the caller should use `load` or `new_or_load`).
evanlinjin
force-pushed
the
fix_overwrite_db
branch
from
c57e0a7 to
a1d34af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NewErroris the error type when constructing a wallet withWallet::new. We want this to return an error when the database already contains data (in which case, the caller should useloadornew_or_load).Notes to the reviewers
This is cherry-picked from #1172 so that we can add it to the alpha.3 release.
Changelog notice
Change
NonEmptyDatabaseerror when constructing a wallet withWallet::newif the file already contains data (in which case, the caller should useloadornew_or_load).Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: