chore: move balance type and anchors mod to chain_data#1283
Closed
startup-dreamer wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
chore: move balance type and anchors mod to chain_data#1283startup-dreamer wants to merge 1 commit intobitcoindevkit:masterfrom
startup-dreamer wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
3 tasks
LLFourn
requested changes
Jan 17, 2024
startup-dreamer
force-pushed
the
move_anchors_mod_and_balance_to_chain_data
branch
from
2872be5 to
6dea9a1
Compare
Author
|
Note (unrelated to PR): GitHub was acting weird for me, that's why this took so long, and I took this issue. I wanted to complete this. Apologies for the delay, @ValuedMammal. Let me know if there are any changes to make. Everything is working fine now. |
Collaborator
|
Approach NACK |
Author
Got it also it's been stale for soo long closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tries to Fix: bitcoindevkit/bdk_wallet#128
Moved anchore mod (dropped
tx_data_traits.rs) andBalancetype tochain_data.rsas suggested in This commentAll Submissions:
cargo fmtandcargo clippybefore committing