chore: rename bdk crate to bdk_wallet#1326
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom May 13, 2024
Merged
Conversation
notmandatory
force-pushed
the
chore/bdk_wallet
branch
5 times, most recently
from
1d1959a to
2e539dc
Compare
Member
|
Thank you for reserving the name! Just a reminder, I don't think we should merge this until the larger PRs are in. |
notmandatory
force-pushed
the
chore/bdk_wallet
branch
2 times, most recently
from
7d0db6a to
f8305ab
Compare
notmandatory
force-pushed
the
chore/bdk_wallet
branch
from
f8305ab to
6286185
Compare
storopoli
approved these changes
Feb 16, 2024
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Looks Good.
After we merge this, we need to also check on bitcoindevkit/bitcoindevkit.org repo and a bunch of other repos 😓
oleonardolima
approved these changes
Mar 22, 2024
storopoli
suggested changes
Mar 24, 2024
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Code-wise I am OK with the changes.
My concerns are with respect to the presentation.
I added some points for us to think and review.
notmandatory
force-pushed
the
chore/bdk_wallet
branch
from
6286185 to
79cf5a6
Compare
Member
Author
|
Rebased on master. |
notmandatory
force-pushed
the
chore/bdk_wallet
branch
2 times, most recently
from
ac671d2 to
28f6855
Compare
storopoli
approved these changes
Mar 25, 2024
notmandatory
force-pushed
the
chore/bdk_wallet
branch
2 times, most recently
from
0993d22 to
30854de
Compare
Member
Author
|
Rebased again on master. |
storopoli
approved these changes
Apr 24, 2024
notmandatory
force-pushed
the
chore/bdk_wallet
branch
2 times, most recently
from
c82d6fc to
99acf17
Compare
notmandatory
force-pushed
the
chore/bdk_wallet
branch
from
99acf17 to
51cbd74
Compare
Member
Author
|
Rebased after alpha.11 release and ready to go. |
storopoli
approved these changes
May 13, 2024
notmandatory
force-pushed
the
chore/bdk_wallet
branch
3 times, most recently
from
217a942 to
7a8af0a
Compare
Member
Author
|
Oops, I had to fix a couple post merge fixes and formatting and hadn't pushed them, pushed them now. |
storopoli
approved these changes
May 13, 2024
notmandatory
force-pushed
the
chore/bdk_wallet
branch
from
7a8af0a to
f678165
Compare
Member
Author
|
Also published new crate: https://crates.io/crates/bdk_wallet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1305 .
Notes to the reviewers
Once this properly builds, even before all reviews is done, I will publish it to crates.io to reserve the name.
Changelog notice
Changed
bdkcrate tobdk_wallet.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing