refactor: replace get_address & get_balance to address & balance resp#1370
refactor: replace get_address & get_balance to address & balance resp#137015IITian wants to merge 1 commit intobitcoindevkit:masterfrom
get_address & get_balance to address & balance resp#1370Conversation
|
@15IITian are you applying for the summer of bitcoin program? If so I recommend less focus on trivial issues like this one that do not demonstrate any knowledge of bitcoin or rust skills. Otherwise these PRs are fine for just getting some practice with basic rust and the github PR review process. |
Yes
Noted and thanks for it. |
|
You should follow the PR template that should have been added to this PR automatically. In particular it helps reviewers to see a summary description of exactly what you're changing. Also rather than just putting the issue # that is being fixed if you say "fixes #" then github will automatically link the issue to the PR. |
|
This is a small change but I think we should push it to the 2.0 milestone. |
|
Closing since this address changes were fixed by #1402 and the can be fixed in another PR. |
Description
Rename the
get_addresstoaddress&get_balancetobalance-> and make subsequent changes in the codebase.Notes to the reviewers
This is done in order to make methods names according with rust API naming guidelines
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
Fix #1221