Skip to content

refactor: replace get_address & get_balance to address & balance resp#1370

Closed
15IITian wants to merge 1 commit intobitcoindevkit:masterfrom
15IITian:get
Closed

refactor: replace get_address & get_balance to address & balance resp#1370
15IITian wants to merge 1 commit intobitcoindevkit:masterfrom
15IITian:get

Conversation

@15IITian
Copy link
Copy Markdown

@15IITian 15IITian commented Mar 6, 2024

Description

Rename the get_address to address & get_balance to balance -> and make subsequent changes in the codebase.

Notes to the reviewers

This is done in order to make methods names according with rust API naming guidelines

Checklists

All Submissions:

Bugfixes:

  • This pull request breaks the existing API
  • I'm linking the issue being fixed by this PR

Fix #1221

@notmandatory
Copy link
Copy Markdown
Member

@15IITian are you applying for the summer of bitcoin program? If so I recommend less focus on trivial issues like this one that do not demonstrate any knowledge of bitcoin or rust skills. Otherwise these PRs are fine for just getting some practice with basic rust and the github PR review process.

@15IITian
Copy link
Copy Markdown
Author

15IITian commented Mar 8, 2024

@15IITian are you applying for the summer of bitcoin program?

Yes

I recommend less focus on trivial issues like this one that do not demonstrate any knowledge of bitcoin or rust skills.

Noted and thanks for it.

Comment thread CHANGELOG.md Outdated
@notmandatory notmandatory added module-wallet api A breaking API change labels Mar 16, 2024
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Mar 16, 2024

You should follow the PR template that should have been added to this PR automatically. In particular it helps reviewers to see a summary description of exactly what you're changing.

Also rather than just putting the issue # that is being fixed if you say "fixes #" then github will automatically link the issue to the PR.

@15IITian 15IITian marked this pull request as ready for review March 16, 2024 16:33
@notmandatory
Copy link
Copy Markdown
Member

This is a small change but I think we should push it to the 2.0 milestone.

@notmandatory
Copy link
Copy Markdown
Member

Closing since this address changes were fixed by #1402 and the can be fixed in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change module-wallet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

refactor(bdk): use idiomatic naming for all getter methods

2 participants