bdk_hwi, set cargo bdk version to 1.0.0-alpha.8#1392
Closed
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
bdk_hwi, set cargo bdk version to 1.0.0-alpha.8#1392notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
notmandatory
force-pushed
the
fix/bdk_hwi_publish
branch
from
aee40d8 to
67d23c8
Compare
notmandatory
force-pushed
the
fix/bdk_hwi_publish
branch
from
67d23c8 to
58531ec
Compare
Member
Author
|
Will make these fixes in #1449. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Need to set a specific version for the
bdk_walletdependency in order to be able to publishbdk_hwito crates.io. I also added a README file since it is also a warning if a crate is published without one.cargo publish -p bdk_hwi Updating crates.io index error: all dependencies must have a version specified when publishing. dependency `bdk` does not specify a version Note: The published dependency will use the version from crates.io, the `path` specification will be removed from the dependency declaration.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing