Fix: enable blocking-https-rustls feature on esplora client#1408
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Apr 20, 2024
Merged
Conversation
Member
|
🔧 I'd prefer you add the |
934d96c to
d3a14d4
Compare
Member
Author
|
Sounds good. I fixed the features as per recommendation. |
storopoli
reviewed
Apr 19, 2024
Closed
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
blockingfeature on the rust-esplora-client library changed from ureq to minreq, which does not come with https enabled by default, breaking previously working code that simply enabled theblockingfeature on thebdk_esploracrate.This change will enable what is currently the "default https" flag for the minreq library when using the
blockingfeature on bdk_esplora, reverting that breaking change.Notes to the reviewers
Another way we could do this (let me know if this is preferable) is to add a new feature called
blocking-https-rustls:Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: