Add new crate bdk-persist#1412
Conversation
ValuedMammal
left a comment
There was a problem hiding this comment.
Additional note that the wallet README has links to PersistBackend that should be updated to point to the new bdk_persist crate. So far, that's the only other thing that stood out to me.
|
Thanks for those suggestions, updated |
|
LGTM. I built and ran the example crates to check that persistence still works, also built the docs locally and found no issues (assuming the new crate will be published to docs.rs). |
|
Thanks for those checks, appreciate it. I also clicked around the docs locally and it linked properly. Think I caught them all with a |
6940643 to
b89dc4f
Compare
b89dc4f to
81de8f6
Compare
|
Just a minor check: are we adding the new |
| version = "0.1.0" | ||
| repository = "https://github.com/bitcoindevkit/bdk" | ||
| documentation = "https://docs.rs/bdk_persist" | ||
| description = "Types that define data persistence of a BDK wallet" |
There was a problem hiding this comment.
Nit: *Types used for persisting bdk_chain data.
Description
#1387 introduced
anyhowas a dependency to remove generics fromWallet. Introducing a new crate for persistence types removes the dependency onanyhowforbdk_chain. Resolves #1409, as well as removing the old documentation for "tracker".Notes to the reviewers
Open for any comments.
Changelog notice
bdk-persistcrateChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: