chore: clean up electrsd and anyhow dev dependencies#1414
Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom May 6, 2024
Merged
chore: clean up electrsd and anyhow dev dependencies#1414evanlinjin merged 2 commits intobitcoindevkit:masterfrom
electrsd and anyhow dev dependencies#1414evanlinjin merged 2 commits intobitcoindevkit:masterfrom
Conversation
LagginTimes
force-pushed
the
electrsd_reexport
branch
2 times, most recently
from
ff19ca8 to
ec34ad1
Compare
LagginTimes
changed the title
electrsd in TestEnvelectrsd and anyhow dev dependencies from electrum and esplora
LagginTimes
force-pushed
the
electrsd_reexport
branch
from
50d1792 to
c8e9913
Compare
storopoli
reviewed
Apr 26, 2024
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Why not encompass also bitcoind_rpc crate?
bdk/crates/bitcoind_rpc/Cargo.toml
Lines 21 to 23 in 8e73998
Contributor
Author
Good point. I had so far only been focusing on |
LagginTimes
force-pushed
the
electrsd_reexport
branch
2 times, most recently
from
70e9e01 to
eec2ed4
Compare
LagginTimes
changed the title
electrsd and anyhow dev dependencies from electrum and esploraelectrsd and anyhow dev dependencies
storopoli
reviewed
Apr 26, 2024
evanlinjin
requested changes
Apr 27, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Nice, just a small complaint.
LagginTimes
force-pushed
the
electrsd_reexport
branch
from
eec2ed4 to
19207d3
Compare
evanlinjin
reviewed
Apr 29, 2024
LagginTimes
force-pushed
the
electrsd_reexport
branch
4 times, most recently
from
7499910 to
9ed2a34
Compare
storopoli
approved these changes
May 3, 2024
Member
|
Please remember to include the changelog notice in the PR description! |
Member
|
@LagginTimes please complete this! |
LagginTimes
force-pushed
the
electrsd_reexport
branch
from
9ed2a34 to
f6218e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reexports
electrsdinTestEnvto remove theelectrsddev depedency out ofbdk_electrumandbdk_esplora.Credit to @ValuedMammal for the idea.
Since
bitcoindreexportsanyhow, this dev dependency was also removed frombdk_electrum,bdk_esplora, andbdk_bitcoind_rpc.bitcoind,bitcoincore_rpcandelectrum_clientwere also reexported for convenience.Changelog notice
bdk_testenvto re-export internally used crates.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing