test(wallet): add thread safety test#1417
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom May 4, 2024
Merged
Conversation
storopoli
approved these changes
May 1, 2024
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Concept ACK, these tiny but powerful tests are really a nice addition.
evanlinjin
approved these changes
May 2, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ACK ac18525
Good idea, thanks for doing this.
rustaceanrob
force-pushed
the
thread-safety
branch
from
ac18525 to
db47347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Walletauto-implementsSendandSyncafter removing the generic. This test is a compile time error if there are changes toWalletin the future that make it unsafe to send between threads. See #1387 for discussion.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: