Bump bdk version to 1.0.0-alpha.10#1420
Merged
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom May 2, 2024
Merged
Conversation
3 tasks
danielabrozzoni
added a commit
that referenced
this pull request
May 2, 2024
a5fb7fd fix: Cargo clippy lints after rust 1.78 (Daniela Brozzoni) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Caught when trying to release (#1420), clippy failed randomly although it worked on master, this happened because rust 1.78 had just been release and we use clippy stable. IMHO we should pin the clippy version in CI and bump it manually at each new rust release. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK a5fb7fd Tree-SHA512: c803366367576224f9e9690cdee2c0161fc083550355415f9174e93ada2f597440f54ac966bb3ebecdc916824d43de17ac72801e4ef0f75c8a1df640fe40df6d
danielabrozzoni
force-pushed
the
bump_dev_1.0.0_alpha.10
branch
from
3c01d79 to
d2e0f64
Compare
notmandatory
reviewed
May 2, 2024
| bdk_chain = { path = "../chain", version = "0.12.0", features = [ "serde", "miniscript" ] } | ||
| bdk_persist = { path = "../persist", version = "0.1.0"} | ||
| bdk_chain = { path = "../chain", version = "0.13.0", features = [ "serde", "miniscript" ] } | ||
| bdk_persist = { path = "../persist", version = "0.2.0"} |
Member
There was a problem hiding this comment.
Suggested change
| bdk_persist = { path = "../persist", version = "0.2.0"} | |
| bdk_persist = { path = "../persist", version = "0.1.0"} |
| name = "bdk_persist" | ||
| homepage = "https://bitcoindevkit.org" | ||
| version = "0.1.0" | ||
| version = "0.2.0" |
Member
There was a problem hiding this comment.
🔧 Don't need to bump this one since it's the first release.
Suggested change
| version = "0.2.0" | |
| version = "0.1.0" |
Member
|
Everything looks good, just one small change and can be merged. |
notmandatory
approved these changes
May 2, 2024
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK d2e0f64
Needs those couple changes but ACKing now so you can merge when you're ready.
bdk_chain to 0.13.0 bdk_bitcoind_rpc to 0.9.0 bdk_electrum to 0.12.0 bdk_esplora to 0.12.0 bdk_file_store to 0.10.0 bdk_testenv to 0.3.0 bdk_persist to 0.2.0
danielabrozzoni
force-pushed
the
bump_dev_1.0.0_alpha.10
branch
from
d2e0f64 to
2cda9f4
Compare
storopoli
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bdk_chain to 0.13.0
bdk_bitcoind_rpc to 0.9.0
bdk_electrum to 0.12.0
bdk_esplora to 0.12.0
bdk_file_store to 0.10.0
bdk_testenv to 0.3.0
bdk_persist to 0.2.0
Checklists
All Submissions: