chore: add print_stdout/print_stderr lints to workspace level#1425
Conversation
a02d3c8 to
1524524
Compare
|
This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they should be allowed is in the examples. |
I'm fine with it either way, but I don't see a problem with allowing it for tests. |
1524524 to
9f69ee5
Compare
9f69ee5 to
24c6655
Compare
evanlinjin
left a comment
There was a problem hiding this comment.
Concept ACK
Just needs a rebase! We got rid of the bdk_persist crate.
08a35f3 to
1ca153a
Compare
notmandatory
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up, I'd just like to remove the println!() from all tests to make cargo test output more readable. If someone really needs to print stuff while debugging tests they can remove or comment out the print lines.
1ca153a to
4cd21c1
Compare
4ba2a4c to
026ba3a
Compare
026ba3a to
e063ad8
Compare
notmandatory
left a comment
There was a problem hiding this comment.
ACK e063ad8
Looks great! much easier to read through the test output with out all the println noise.
potentially fixes #1362
Description
It adds both
print_stdoutandprint_stderrdeny level lints on workspace level, but it does allow it on test fns throughclippy.tomlsettings, and explicitly allow it on example code.Notes to the reviewers
It currently has the setting allowing it on test fns, but open for discussion below.
Changelog notice
print_stdoutandprint_stderrdeny level lints on workspace levelChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: