refactor(wallet): rename get_balance() to balance()#1455
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jun 4, 2024
Merged
refactor(wallet): rename get_balance() to balance()#1455notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
Contributor
|
ACK 50137b0 |
storopoli
reviewed
Jun 3, 2024
| @@ -1216,7 +1216,7 @@ impl Wallet { | |||
|
|
|||
| /// Return the balance, separated into available, trusted-pending, untrusted-pending and immature | |||
There was a problem hiding this comment.
Suggested change
| /// Return the balance, separated into available, trusted-pending, untrusted-pending and immature | |
| /// Returns the balance, separated into available, trusted-pending, untrusted-pending and immature |
Since we are fixing this anyways let's adjust the docstring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #1221
Notes to the reviewers
See discussion in #1221.
Changelog notice
Changed
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing