fix(wallet)!: Simplify SignOptions and improve finalization logic#1476
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Jun 20, 2024
Merged
Conversation
storopoli
approved these changes
Jun 17, 2024
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Concept ACK.
Nice trick with mem::take.
evanlinjin
approved these changes
Jun 19, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ACK ee8d410
Just a small nit lol
Rather than comingle various `SignOptions` with the finalization step, we simply clear all fields when finalizing as per the PSBT spec in BIPs 174 and 371 which is more in line with user expectations.
ValuedMammal
force-pushed
the
fix/wallet-finalize-psbt
branch
from
ee8d410 to
996605f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than comingle various
SignOptionswith the finalization step, we simply clear all fields when finalizing as per the PSBT spec in BIPs 174 and 371 which is more in line with user expectations.Notes to the reviewers
I chose to re-implement some parts of
finalize_inputsince it's fairly straightforward, see also #1461 (comment). I had to refactor some wallet tests but didn't go out of my way to add additional tests.closes #1461
Changelog notice
remove_partial_sigsfromSignOptionsremove_taproot_extrasfromSignOptionsChecklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: